leds: lp8788: Use devm_led_classdev_register

Switch to resource-managed function devm_led_classdev_register instead
of led_classdev_register and remove unneeded led_classdev_unregister.

Also, remove platform_set_drvdata in probe function and the remove
function, lp8788_led_remove as it is now has nothing to do.

The Coccinelle semantic patch used to make this change is as follows:
//<smpl>
@platform@
identifier p, probefn, removefn;
@@
struct platform_driver p = {
  .probe = probefn,
  .remove = removefn,
};

@prb@
identifier platform.probefn, pdev;
expression e;
@@
probefn(struct platform_device *pdev, ...) {
  ...
  e =
- led_classdev_register
+ devm_led_classdev_register
  (...);
   ...
?- led_classdev_unregister(...);
  ...
}
@remove depends on prb@
identifier platform.removefn;
@@
removefn(...) {
...
?- led_classdev_unregister(...);
...
}
//</smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>

diff --git a/drivers/leds/leds-lp8788.c b/drivers/leds/leds-lp8788.c
index 0eee38fc05651294cf63f433d331e74942746441..38c253a43700627deebce9751382c645d8c11848 100644 (file)
--- a/drivers/leds/leds-lp8788.c
+++ b/drivers/leds/leds-lp8788.c
@@ -146,15 +146,13 @@ static int lp8788_led_probe(struct platform_device *pdev)
 
        mutex_init(&led->lock);
 
-       platform_set_drvdata(pdev, led);
-
        ret = lp8788_led_init_device(led, led_pdata);
        if (ret) {
                dev_err(dev, "led init device err: %d\n", ret);
                return ret;
        }
 
-       ret = led_classdev_register(dev, &led->led_dev);
+       ret = devm_led_classdev_register(dev, &led->led_dev);
        if (ret) {
                dev_err(dev, "led register err: %d\n", ret);
                return ret;
@@ -163,18 +161,8 @@ static int lp8788_led_probe(struct platform_device *pdev)
        return 0;
 }
 
-static int lp8788_led_remove(struct platform_device *pdev)
-{
-       struct lp8788_led *led = platform_get_drvdata(pdev);
-
-       led_classdev_unregister(&led->led_dev);
-
-       return 0;
-}
-
 static struct platform_driver lp8788_led_driver = {
        .probe = lp8788_led_probe,
-       .remove = lp8788_led_remove,
        .driver = {
                .name = LP8788_DEV_KEYLED,
        },