net: dsa: Bring back device detaching in dsa_slave_suspend()
authorFlorian Fainelli <f.fainelli@gmail.com>
Wed, 25 Jan 2017 17:10:41 +0000 (09:10 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 25 Jan 2017 19:47:44 +0000 (14:47 -0500)
Commit 448b4482c671 ("net: dsa: Add lockdep class to tx queues to avoid
lockdep splat") removed the netif_device_detach() call done in
dsa_slave_suspend() which is necessary, and paired with a corresponding
netif_device_attach(), bring it back.

Fixes: 448b4482c671 ("net: dsa: Add lockdep class to tx queues to avoid lockdep splat")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/slave.c

index ba1b6b9630d23b715bd4129a8b65b103715d8740..7d45961108511488003380da656bf8a4f2fd7d84 100644 (file)
@@ -1201,6 +1201,8 @@ int dsa_slave_suspend(struct net_device *slave_dev)
 {
        struct dsa_slave_priv *p = netdev_priv(slave_dev);
 
+       netif_device_detach(slave_dev);
+
        if (p->phy) {
                phy_stop(p->phy);
                p->old_pause = -1;