drm/i915/guc: Remove last submission result from debugfs

Debugfs does not seems to be a right place to display transient data.
If we want to capture errors, we should log them.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170518113104.54400-3-michal.wajdeczko@intel.com
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 207175e527f4da459d07d93ef3ddcda82a0a041f..6bdc903a090b6c3944eafcd0b622625a0ee687de 100644 (file)
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -2482,7 +2482,6 @@ static void i915_guc_client_info(struct seq_file *m,
                client->wq_size, client->wq_offset, client->wq_tail);
 
        seq_printf(m, "\tWork queue full: %u\n", client->no_wq_space);
-       seq_printf(m, "\tLast submission result: %d\n", client->retcode);
 
        for_each_engine(engine, dev_priv, id) {
                u64 submissions = client->submissions[id];

diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c b/drivers/gpu/drm/i915/i915_guc_submission.c
index dc843111143ca16a20641771314b68c302e710d3..ee32fa97a18b5bf001eb22ff36c7d1def73ae95c 100644 (file)
--- a/drivers/gpu/drm/i915/i915_guc_submission.c
+++ b/drivers/gpu/drm/i915/i915_guc_submission.c
@@ -614,7 +614,6 @@ static void __i915_guc_submit(struct drm_i915_gem_request *rq)
        b_ret = guc_ring_doorbell(client);
 
        client->submissions[engine_id] += 1;
-       client->retcode = b_ret;
 
        guc->submissions[engine_id] += 1;
        guc->last_seqno[engine_id] = rq->global_seqno;

diff --git a/drivers/gpu/drm/i915/intel_uc.h b/drivers/gpu/drm/i915/intel_uc.h
index 398a49178b0f6842c3de427315657e036ae4c4d4..33c8f77f72ce75325149f16cbc4d8aa2230e8c67 100644 (file)
--- a/drivers/gpu/drm/i915/intel_uc.h
+++ b/drivers/gpu/drm/i915/intel_uc.h
@@ -59,7 +59,6 @@ struct drm_i915_gem_request;
  *                available in the work queue (note, the queue is shared,
  *                not per-engine). It is OK for this to be nonzero, but
  *                it should not be huge!
- *   retcode: errno from last guc_submit()
  */
 struct i915_guc_client {
        struct i915_vma *vma;
@@ -82,7 +81,6 @@ struct i915_guc_client {
        uint32_t wq_tail;
        uint32_t wq_rsvd;
        uint32_t no_wq_space;
-       int retcode;
 
        /* Per-engine counts of GuC submissions */
        uint64_t submissions[I915_NUM_ENGINES];