USB: option: reduce interrupt-urb logging verbosity
authorJohan Hovold <johan@kernel.org>
Tue, 29 Jul 2014 12:14:55 +0000 (14:14 +0200)
committerJohan Hovold <johan@kernel.org>
Mon, 18 Aug 2014 09:05:37 +0000 (11:05 +0200)
Do not log normal interrupt-urb shutdowns as errors.

The option driver has always been logging any nonzero interrupt-urb
status as an error, including when the urb is killed during normal
operation.

Commit 9096f1fbba91 ("USB: usb_wwan: fix potential NULL-deref at
resume") moved the interrupt urb submission from port probe and release
to open and close, thus potentially increasing the number of these
false-positive error messages dramatically.

Reported-by: Ed Butler <ressy66@ausics.net>
Tested-by: Ed Butler <ressy66@ausics.net>
Cc: <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/option.c

index a9688940543d78d1724f28dae75a0929919e4f25..34f142be5b83b9ba53cd19c0eda6cb05227e7ebd 100644 (file)
@@ -1916,6 +1916,8 @@ static void option_instat_callback(struct urb *urb)
                        dev_dbg(dev, "%s: type %x req %x\n", __func__,
                                req_pkt->bRequestType, req_pkt->bRequest);
                }
+       } else if (status == -ENOENT || status == -ESHUTDOWN) {
+               dev_dbg(dev, "%s: urb stopped: %d\n", __func__, status);
        } else
                dev_err(dev, "%s: error %d\n", __func__, status);