bnxt_en: Fix VF attributes reporting.
authorMichael Chan <michael.chan@broadcom.com>
Sat, 22 Apr 2017 00:11:23 +0000 (20:11 -0400)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 Apr 2017 17:54:46 +0000 (13:54 -0400)
The .ndo_get_vf_config() is returning the wrong qos attribute.  Fix
the code that checks and reports the qos and spoofchk attributes.  The
BNXT_VF_QOS and BNXT_VF_LINK_UP flags should not be set by default
during init. time.

Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c

index f89353175e6b9328e219efe5ccb34c0d95d5ecf2..b8e7248294d9b093129945c61ac4ca34a2667213 100644 (file)
@@ -138,8 +138,11 @@ int bnxt_get_vf_config(struct net_device *dev, int vf_id,
        ivi->max_tx_rate = vf->max_tx_rate;
        ivi->min_tx_rate = vf->min_tx_rate;
        ivi->vlan = vf->vlan;
-       ivi->qos = vf->flags & BNXT_VF_QOS;
-       ivi->spoofchk = vf->flags & BNXT_VF_SPOOFCHK;
+       if (vf->flags & BNXT_VF_QOS)
+               ivi->qos = vf->vlan >> VLAN_PRIO_SHIFT;
+       else
+               ivi->qos = 0;
+       ivi->spoofchk = !!(vf->flags & BNXT_VF_SPOOFCHK);
        if (!(vf->flags & BNXT_VF_LINK_FORCED))
                ivi->linkstate = IFLA_VF_LINK_STATE_AUTO;
        else if (vf->flags & BNXT_VF_LINK_UP)
@@ -304,7 +307,6 @@ static int bnxt_set_vf_attr(struct bnxt *bp, int num_vfs)
        for (i = 0; i < num_vfs; i++) {
                vf = &bp->pf.vf[i];
                memset(vf, 0, sizeof(*vf));
-               vf->flags = BNXT_VF_QOS | BNXT_VF_LINK_UP;
        }
        return 0;
 }