netem: fix gemodel loss generator
authorstephen hemminger <stephen@networkplumber.org>
Fri, 29 Nov 2013 19:04:26 +0000 (11:04 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 30 Nov 2013 17:49:29 +0000 (12:49 -0500)
Patch from developers of the alternative loss models, downloaded from:
   http://netgroup.uniroma2.it/twiki/bin/view.cgi/Main/NetemCLG

 "in case 2, of the switch we change the direction of the inequality to
  net_random()>clg->a3, because clg->a3 is h in the GE model and when h
  is 0 all packets will be lost."

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_netem.c

index 9685624f7bc779a942c822329a95aa0d656b79b9..bccd52b36e97be79d446e233dedc960fe65d5f16 100644 (file)
@@ -272,7 +272,7 @@ static bool loss_gilb_ell(struct netem_sched_data *q)
        case 2:
                if (net_random() < clg->a2)
                        clg->state = 1;
-               if (clg->a3 > net_random())
+               if (net_random() > clg->a3)
                        return true;
        }