ip_vti: fix sparse warnings for VTI_ISVTI
authorDmitry Popov <ixaphire@qrator.net>
Wed, 11 Jun 2014 11:09:14 +0000 (15:09 +0400)
committerDavid S. Miller <davem@davemloft.net>
Wed, 11 Jun 2014 22:39:19 +0000 (15:39 -0700)
This patch fixes the following sparse warnings:

net/ipv4/ip_tunnel.c:245:53: warning: restricted __be16 degrades to integer
net/ipv4/ip_vti.c:321:19: warning: incorrect type in assignment (different base types)
net/ipv4/ip_vti.c:321:19:    expected restricted __be16 [addressable] [assigned] [usertype] i_flags
net/ipv4/ip_vti.c:321:19:    got int
net/ipv4/ip_vti.c:447:24: warning: incorrect type in assignment (different base types)
net/ipv4/ip_vti.c:447:24:    expected restricted __be16 [usertype] i_flags
net/ipv4/ip_vti.c:447:24:    got int

Since VTI_ISVTI is always used with ip_tunnel_parm->i_flags (which is __be16),
we can __force cast VTI_ISVTI to __be16 in header file.

Signed-off-by: Dmitry Popov <ixaphire@qrator.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/uapi/linux/if_tunnel.h

index aee73d0611fb9bbb72f3ab52a0b91c09ba861c12..3bce9e9d9f7c8d82c1e8064904098a73cdd4fb81 100644 (file)
@@ -100,7 +100,7 @@ enum {
 #define IFLA_GRE_MAX   (__IFLA_GRE_MAX - 1)
 
 /* VTI-mode i_flags */
-#define VTI_ISVTI 0x0001
+#define VTI_ISVTI ((__force __be16)0x0001)
 
 enum {
        IFLA_VTI_UNSPEC,