perf/x86/intel/uncore: Remove WARN_ON_ONCE in uncore_pci_probe
authorJiri Olsa <jolsa@redhat.com>
Wed, 18 May 2016 06:16:10 +0000 (08:16 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 18 May 2016 14:17:25 +0000 (16:17 +0200)
When booting with nr_cpus=1, uncore_pci_probe tries to init the PCI/uncore
also for the other packages and fails with warning when they are not found.

The warning is bogus because it's correct to fail here for packages which are
not initialized. Remove it and return silently.

Fixes: cf6d445f6897 "perf/x86/uncore: Track packages, not per CPU data"
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: stable@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
arch/x86/events/intel/uncore.c

index 16c1789164122b70f6d2cd4ad16ae18b741236aa..fce74062d9812031b491d997f1e995578ccf8af9 100644 (file)
@@ -891,7 +891,7 @@ static int uncore_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id
                return -ENODEV;
 
        pkg = topology_phys_to_logical_pkg(phys_id);
-       if (WARN_ON_ONCE(pkg < 0))
+       if (pkg < 0)
                return -EINVAL;
 
        if (UNCORE_PCI_DEV_TYPE(id->driver_data) == UNCORE_EXTRA_PCI_DEV) {