ALSA: hda - Clear the leftover component assignment at snd_hdac_i915_exit()
authorTakashi Iwai <tiwai@suse.de>
Tue, 29 Mar 2016 10:29:24 +0000 (12:29 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 25 Dec 2017 13:22:16 +0000 (14:22 +0100)
commit faafd03d23c913633d2ef7e6ffebdce01b164409 upstream.

The commit [d745f5e7b8b2: ALSA: hda - Add the pin / port mapping on
Intel ILK and VLV] introduced a WARN_ON() to check the pointer for
avoiding the double initializations.  But hdac_acomp pointer wasn't
cleared at snd_hdac_i915_exit(), thus after reloading the HD-audio
driver, it may result in the false positive warning.  This patch makes
sure to clear the leftover pointer at exit.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94736
Reported-by: Daniela Doras-prodan <daniela.doras-prodan@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Cc: Kouta Okamoto <kouta.okamoto@toshiba.co.jp>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/hda/hdac_i915.c

index 8fef1b8d1fd8acc443bc86a2aedd66763d9b84fd..166d2eb8fd6b456038bfef7d9d3a09c8399d6602 100644 (file)
@@ -273,6 +273,7 @@ int snd_hdac_i915_exit(struct hdac_bus *bus)
 
        kfree(acomp);
        bus->audio_component = NULL;
+       hdac_acomp = NULL;
 
        return 0;
 }