IB/rdmavt: Correct sparse annotation
authorMike Marciniszyn <mike.marciniszyn@intel.com>
Tue, 6 Sep 2016 11:36:33 +0000 (04:36 -0700)
committerDoug Ledford <dledford@redhat.com>
Sun, 2 Oct 2016 12:42:08 +0000 (08:42 -0400)
The __must_hold() is sufficent to correct the sparse
context imbalance inside a function.

Per Documentation/sparse.txt:
__must_hold - The specified lock is held on function entry and exit.

Fixes: Commit c0a67f6ba356 ("IB/rdmavt: Annotate rvt_reset_qp()")
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/sw/rdmavt/qp.c

index da5c8d6eed9981fa2a7572ceedcb378bb72e7130..80d2c50f96a3d68d80c69f4489b2d9a07e1e86d2 100644 (file)
@@ -500,12 +500,9 @@ static void rvt_remove_qp(struct rvt_dev_info *rdi, struct rvt_qp *qp)
  */
 static void rvt_reset_qp(struct rvt_dev_info *rdi, struct rvt_qp *qp,
                  enum ib_qp_type type)
-       __releases(&qp->s_lock)
-       __releases(&qp->s_hlock)
-       __releases(&qp->r_lock)
-       __acquires(&qp->r_lock)
-       __acquires(&qp->s_hlock)
-       __acquires(&qp->s_lock)
+       __must_hold(&qp->r_lock)
+       __must_hold(&qp->s_hlock)
+       __must_hold(&qp->s_lock)
 {
        if (qp->state != IB_QPS_RESET) {
                qp->state = IB_QPS_RESET;