aacraid: Remove code to needlessly complete fib
authorRaghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
Tue, 26 Apr 2016 06:32:26 +0000 (23:32 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 29 Apr 2016 23:08:24 +0000 (19:08 -0400)
Currently driver completes double completed or spurious interrupted fibs.
This  is not necessary and causes the SCSI mid layer to issue aborts and
resets, since completing a fib  prematurely might trigger a race condition
resulting in the driver not calling the scsi_done callback.

Fixed by removing the call to fib complete.

Signed-off-by: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/aacraid/dpcsup.c

index d677b52860ae35df7c63e8e0972b3c167a48aa21..7e836205aef1707b65ccc46ab5c49fbad95ee0b2 100644 (file)
@@ -392,9 +392,10 @@ unsigned int aac_intr_normal(struct aac_dev *dev, u32 index,
                        if (likely(fib->callback && fib->callback_data)) {
                                fib->flags &= FIB_CONTEXT_FLAG_FASTRESP;
                                fib->callback(fib->callback_data, fib);
-                       } else {
-                               aac_fib_complete(fib);
-                       }
+                       } else
+                               dev_info(&dev->pdev->dev,
+                               "Invalid callback_fib[%d] (*%p)(%p)\n",
+                               index, fib->callback, fib->callback_data);
                } else {
                        unsigned long flagv;
                        dprintk((KERN_INFO "event_wait up\n"));