pkt_sched: Fix "parent is root" test in qdisc_create().
authorDavid S. Miller <davem@davemloft.net>
Thu, 7 Aug 2008 06:35:59 +0000 (23:35 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 7 Aug 2008 06:35:59 +0000 (23:35 -0700)
As noticed by Stephen Hemminger, the root qdisc is denoted by
TC_H_ROOT, not zero.

Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_api.c

index 4840aff4725603295d4eef1ebca7f24cd5f9a853..83b23b55ce363e4a696a2c1f3ae8f59a089db2d2 100644 (file)
@@ -792,7 +792,7 @@ qdisc_create(struct net_device *dev, struct netdev_queue *dev_queue,
                                goto err_out3;
                        }
                }
-               if (parent && !(sch->flags & TCQ_F_INGRESS))
+               if ((parent != TC_H_ROOT) && !(sch->flags & TCQ_F_INGRESS))
                        list_add_tail(&sch->list, &dev_queue->qdisc->list);
 
                return sch;