drm: qxl: add missing return check
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 14 Mar 2017 07:54:10 +0000 (10:54 +0300)
committerGerd Hoffmann <kraxel@redhat.com>
Tue, 14 Mar 2017 10:54:20 +0000 (11:54 +0100)
My static checker complains that "release" is uninitialized if
qxl_alloc_release_reserved() fails, so let's add a check for that.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170314075410.GB5984@mwanda
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
drivers/gpu/drm/qxl/qxl_display.c

index 9548bb58d3bcfc34c295ebd761f2302bda556ad8..058340a002c29daef072f21bf90e1e8a572b3fa9 100644 (file)
@@ -572,6 +572,8 @@ static void qxl_cursor_atomic_update(struct drm_plane *plane,
        ret = qxl_alloc_release_reserved(qdev, sizeof(*cmd),
                                         QXL_RELEASE_CURSOR_CMD,
                                         &release, NULL);
+       if (ret)
+               return;
 
        cmd = (struct qxl_cursor_cmd *) qxl_release_map(qdev, release);