sfc: fix an off by one bug
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 7 Feb 2017 07:44:31 +0000 (10:44 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 7 Feb 2017 19:00:37 +0000 (14:00 -0500)
This bug is harmless because it's just a sanity check and we always
pass valid values for "encap_type" but the test is off by one.

Fixes: 9b4108012517 ("sfc: insert catch-all filters for encapsulated traffic")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Bert Kenward <bkenward@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/ef10.c

index 0475f1831b9222d51cf3b469278f4ac19e29c02e..dec0c8083ff33db5365416c220a1d66b7162ee75 100644 (file)
@@ -5134,7 +5134,7 @@ static int efx_ef10_filter_insert_def(struct efx_nic *efx,
 
                /* quick bounds check (BCAST result impossible) */
                BUILD_BUG_ON(EFX_EF10_BCAST != 0);
-               if (encap_type > ARRAY_SIZE(map) || map[encap_type] == 0) {
+               if (encap_type >= ARRAY_SIZE(map) || map[encap_type] == 0) {
                        WARN_ON(1);
                        return -EINVAL;
                }