staging: iio: accel: fix error check
authorLuis de Bethencourt <luisbg@osg.samsung.com>
Wed, 22 Jun 2016 19:43:30 +0000 (20:43 +0100)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:13:43 +0000 (13:13 +0000)
commit ef3149eb3ddb7f9125e11c90f8330e371b55cffd upstream.

sca3000_read_ctrl_reg() returns a negative number on failure, check for
this instead of zero.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/staging/iio/accel/sca3000_core.c

index 32950ad9485777609a3ab0be9365444e529f557e..b30c41b3e0cc19cfe8ff6babaebf6c3e477e6bf9 100644 (file)
@@ -588,7 +588,7 @@ static ssize_t sca3000_read_frequency(struct device *dev,
                goto error_ret_mut;
        ret = sca3000_read_ctrl_reg(st, SCA3000_REG_CTRL_SEL_OUT_CTRL);
        mutex_unlock(&st->lock);
-       if (ret)
+       if (ret < 0)
                goto error_ret;
        val = ret;
        if (base_freq > 0)