IB/mlx4: Convert kmalloc to kmalloc_array for checkpatch
authorLeon Romanovsky <leonro@mellanox.com>
Thu, 17 Dec 2015 07:31:53 +0000 (09:31 +0200)
committerDoug Ledford <dledford@redhat.com>
Thu, 24 Dec 2015 05:17:32 +0000 (00:17 -0500)
Convert kmalloc to be kmalloc_array to fix warnings below:

WARNING: Prefer kmalloc_array over kmalloc with multiply
+               qp->sq.wrid = kmalloc(qp->sq.wqe_cnt * sizeof(u64),

WARNING: Prefer kmalloc_array over kmalloc with multiply
+               qp->rq.wrid = kmalloc(qp->rq.wqe_cnt * sizeof(u64),

WARNING: Prefer kmalloc_array over kmalloc with multiply
+               srq->wrid = kmalloc(srq->msrq.max * sizeof(u64),

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Or Gerlitz <ogerlitz@mellanox.com>
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/mlx4/qp.c
drivers/infiniband/hw/mlx4/srq.c

index 9ed7b7fec5dae6cb317f140b05c23a0e4801b78d..8d280594e24bfd24504df36df56b1e2649bbe846 100644 (file)
@@ -795,12 +795,12 @@ static int create_qp_common(struct mlx4_ib_dev *dev, struct ib_pd *pd,
                if (err)
                        goto err_mtt;
 
-               qp->sq.wrid = kmalloc(qp->sq.wqe_cnt * sizeof(u64),
+               qp->sq.wrid = kmalloc_array(qp->sq.wqe_cnt, sizeof(u64),
                                        gfp | __GFP_NOWARN);
                if (!qp->sq.wrid)
                        qp->sq.wrid = __vmalloc(qp->sq.wqe_cnt * sizeof(u64),
                                                gfp, PAGE_KERNEL);
-               qp->rq.wrid = kmalloc(qp->rq.wqe_cnt * sizeof(u64),
+               qp->rq.wrid = kmalloc_array(qp->rq.wqe_cnt, sizeof(u64),
                                        gfp | __GFP_NOWARN);
                if (!qp->rq.wrid)
                        qp->rq.wrid = __vmalloc(qp->rq.wqe_cnt * sizeof(u64),
index f416c7463827e55b702434c4c14d7553832ecf12..68d5a5fda271324a471284f4634809ebcb520b5b 100644 (file)
@@ -171,7 +171,7 @@ struct ib_srq *mlx4_ib_create_srq(struct ib_pd *pd,
                if (err)
                        goto err_mtt;
 
-               srq->wrid = kmalloc(srq->msrq.max * sizeof(u64),
+               srq->wrid = kmalloc_array(srq->msrq.max, sizeof(u64),
                                        GFP_KERNEL | __GFP_NOWARN);
                if (!srq->wrid) {
                        srq->wrid = __vmalloc(srq->msrq.max * sizeof(u64),