PCI: pciehp: Ignore interrupts during D3cold
authorLukas Wunner <lukas@wunner.de>
Fri, 13 May 2016 11:15:31 +0000 (13:15 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 20 Jun 2016 18:58:36 +0000 (13:58 -0500)
If a hotplug port is suspended to D3cold, its slot status register cannot
be read.  If that hotplug port happens to share its IRQ with other devices,
whenever an interrupt occurs for one of these devices, pciehp logs a
"no response from device" message and tries to read the PCI_EXP_SLTSTA
register, even though we know that will fail.

Ignore interrupts while we're in D3cold.

[bhelgaas: changelog]
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/hotplug/pciehp_hpc.c

index 5c24e938042fd6bccb4e207d58dcb988d7c62611..08e84d61874e104ac7479f132d830f5fca98861a 100644 (file)
@@ -546,6 +546,10 @@ static irqreturn_t pcie_isr(int irq, void *dev_id)
        u8 present;
        bool link;
 
+       /* Interrupts cannot originate from a controller that's asleep */
+       if (pdev->current_state == PCI_D3cold)
+               return IRQ_NONE;
+
        /*
         * In order to guarantee that all interrupt events are
         * serviced, we need to re-inspect Slot Status register after