ppc: bpf_jit: can call module_free() from any context
authorDaniel Borkmann <dborkman@redhat.com>
Mon, 20 May 2013 08:05:50 +0000 (08:05 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 20 May 2013 21:03:50 +0000 (14:03 -0700)
Followup patch on module_free()/vfree() that takes care of the rest, so
no longer this workaround with work_struct is needed.

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Matt Evans <matt@ozlabs.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
arch/powerpc/net/bpf_jit_comp.c

index c427ae36374ab4fa6eb1503c15b07de2926006e6..bf56e33f8257f68717b241c98abefb2f925f2858 100644 (file)
@@ -650,8 +650,7 @@ void bpf_jit_compile(struct sk_filter *fp)
 
        proglen = cgctx.idx * 4;
        alloclen = proglen + FUNCTION_DESCR_SIZE;
-       image = module_alloc(max_t(unsigned int, alloclen,
-                                  sizeof(struct work_struct)));
+       image = module_alloc(alloclen);
        if (!image)
                goto out;
 
@@ -688,20 +687,8 @@ out:
        return;
 }
 
-static void jit_free_defer(struct work_struct *arg)
-{
-       module_free(NULL, arg);
-}
-
-/* run from softirq, we must use a work_struct to call
- * module_free() from process context
- */
 void bpf_jit_free(struct sk_filter *fp)
 {
-       if (fp->bpf_func != sk_run_filter) {
-               struct work_struct *work = (struct work_struct *)fp->bpf_func;
-
-               INIT_WORK(work, jit_free_defer);
-               schedule_work(work);
-       }
+       if (fp->bpf_func != sk_run_filter)
+               module_free(NULL, fp->bpf_func);
 }