zero the stack buffer before giving random garbage to the SCU
authorArjan van de Ven <arjan@linux.intel.com>
Mon, 26 Jul 2010 09:04:37 +0000 (10:04 +0100)
committerMatthew Garrett <mjg@redhat.com>
Tue, 3 Aug 2010 13:50:31 +0000 (09:50 -0400)
some messages take 4 bytes, but only fill 3 bytes....
this patch makes sure that whatever we send to the SCU is zeroed first

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
drivers/platform/x86/intel_scu_ipc.c

index 1b0d0d54cb0fec07e9ece9dfafc481db5808d113..b903420fa973fb0c6c6dedae218d4990f6c345c1 100644 (file)
@@ -162,6 +162,8 @@ static int pwr_reg_rdwr(u16 *addr, u8 *data, u32 count, u32 op, u32 id)
 
        mutex_lock(&ipclock);
 
+       memset(cbuf, 0, sizeof(cbuf));
+
        if (ipcdev.pdev == NULL) {
                mutex_unlock(&ipclock);
                return -ENODEV;