UBI: remove PEB from free tree in get_peb_for_wl()
authorRichard Weinberger <richard@nod.at>
Mon, 3 Dec 2012 19:57:46 +0000 (20:57 +0100)
committerArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Tue, 4 Dec 2012 14:04:16 +0000 (16:04 +0200)
If UBI is built without fastmap, get_peb_for_wl() has to
remove the PEB manially from the free tree.
Otherwise the requested PEB lives in two trees.

Reported-by: Zach Sadecki <zsadecki@itwatchdogs.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
drivers/mtd/ubi/wl.c

index da7b44998b402866643ef824055d6ed3916bcf4f..1f9f5f7a5d0fe24c5b4b56d36798f2f072b92fd2 100644 (file)
@@ -679,7 +679,13 @@ static struct ubi_wl_entry *get_peb_for_wl(struct ubi_device *ubi)
 #else
 static struct ubi_wl_entry *get_peb_for_wl(struct ubi_device *ubi)
 {
-       return find_wl_entry(ubi, &ubi->free, WL_FREE_MAX_DIFF);
+       struct ubi_wl_entry *e;
+
+       e = find_wl_entry(ubi, &ubi->free, WL_FREE_MAX_DIFF);
+       self_check_in_wl_tree(ubi, e, &ubi->free);
+       rb_erase(&e->u.rb, &ubi->free);
+
+       return e;
 }
 
 int ubi_wl_get_peb(struct ubi_device *ubi)