scsi: Make checking the scsi_device_get() return value mandatory
authorBart Van Assche <bart.vanassche@sandisk.com>
Wed, 5 Apr 2017 16:52:50 +0000 (09:52 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 6 Apr 2017 16:45:38 +0000 (12:45 -0400)
Now that all scsi_device_get() callers check the return value of this
function, make checking that return value mandatory.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
include/scsi/scsi_device.h

index 6f22b39f1b0c3bc8bb1812a631a638ef1987a784..d2a735ac482ba6b4344509cc264a30c5704bc379 100644 (file)
@@ -316,7 +316,7 @@ extern int scsi_unregister_device_handler(struct scsi_device_handler *scsi_dh);
 void scsi_attach_vpd(struct scsi_device *sdev);
 
 extern struct scsi_device *scsi_device_from_queue(struct request_queue *q);
-extern int scsi_device_get(struct scsi_device *);
+extern int __must_check scsi_device_get(struct scsi_device *);
 extern void scsi_device_put(struct scsi_device *);
 extern struct scsi_device *scsi_device_lookup(struct Scsi_Host *,
                                              uint, uint, u64);