IB/mthca: use swap() in mthca_make_profile()
authorFabian Frederick <fabf@skynet.be>
Wed, 10 Jun 2015 16:31:51 +0000 (18:31 +0200)
committerDoug Ledford <dledford@redhat.com>
Thu, 11 Jun 2015 05:10:59 +0000 (01:10 -0400)
Use kernel.h macro definition.

Thanks to Julia Lawall for Coccinelle scripting support.

Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/mthca/mthca_profile.c

index 8edb28a9a0e7593168f4b45d5ab9c4d3c1a8507c..15d064479ef6c5347f48ef804aa380a0c5eadb0f 100644 (file)
@@ -77,7 +77,6 @@ s64 mthca_make_profile(struct mthca_dev *dev,
        u64 mem_base, mem_avail;
        s64 total_size = 0;
        struct mthca_resource *profile;
-       struct mthca_resource tmp;
        int i, j;
 
        profile = kzalloc(MTHCA_RES_NUM * sizeof *profile, GFP_KERNEL);
@@ -136,11 +135,8 @@ s64 mthca_make_profile(struct mthca_dev *dev,
         */
        for (i = MTHCA_RES_NUM; i > 0; --i)
                for (j = 1; j < i; ++j) {
-                       if (profile[j].size > profile[j - 1].size) {
-                               tmp            = profile[j];
-                               profile[j]     = profile[j - 1];
-                               profile[j - 1] = tmp;
-                       }
+                       if (profile[j].size > profile[j - 1].size)
+                               swap(profile[j], profile[j - 1]);
                }
 
        for (i = 0; i < MTHCA_RES_NUM; ++i) {