drm: fix drm_cache.c for arch with no support.
authorDave Airlie <airlied@linux.ie>
Tue, 1 Sep 2009 23:41:13 +0000 (09:41 +1000)
committerDave Airlie <airlied@linux.ie>
Tue, 1 Sep 2009 23:41:13 +0000 (09:41 +1000)
This produces a warn on for architectures where this gets called
but we don't have a cache flushing implementation suitable.

Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/drm_cache.c

index 3a5575e638dbb03a317a716d2fe15161dcc652a0..0e3bd5b54b78c57ba7fcf3df524aedaa32bf366e 100644 (file)
@@ -62,11 +62,8 @@ drm_clflush_ipi_handler(void *null)
 {
        wbinvd();
 }
-#elif !defined(__powerpc__)
-static void drm_cache_ipi_handler(void *dummy)
-{
-}
 #endif
+
 void
 drm_clflush_pages(struct page *pages[], unsigned long num_pages)
 {
@@ -95,8 +92,8 @@ drm_clflush_pages(struct page *pages[], unsigned long num_pages)
                kunmap_atomic(page_virtual, KM_USER0);
        }
 #else
-       if (on_each_cpu(drm_clflush_ipi_handler, NULL, 1) != 0)
-               printk(KERN_ERR "Timed out waiting for drm cache flush\n");
+       printk(KERN_ERR "Architecture has no drm_cache.c support\n");
+       WARN_ON_ONCE(1);
 #endif
 }
 EXPORT_SYMBOL(drm_clflush_pages);