Staging: comedi: Correct a few printf format codes
authorChase Southwood <chase.southwood@yahoo.com>
Wed, 12 Feb 2014 08:28:35 +0000 (02:28 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 12 Feb 2014 17:32:17 +0000 (09:32 -0800)
My static checker found some slightly inaccurate format codes in printf
calls in comedi_fops.c and drivers/comedi_bond.c.  It may be slightly
pedantic to change them, but using the correctly corresponding format
codes is probably a good idea.  All but one were unsigned ints that were
formatted with %i, change these to %u, and one was an int formatted with
%u, we want to format this with %d.

Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/comedi_fops.c
drivers/staging/comedi/drivers/comedi_bond.c

index c22c617b0da1fdb30af4082e4bfc2a1e534a2cb8..b36b76060d03b638b48f3bda05461702ad791780 100644 (file)
@@ -297,7 +297,7 @@ static ssize_t max_read_buffer_kb_show(struct device *csdev,
        mutex_unlock(&dev->mutex);
 
        comedi_dev_put(dev);
-       return snprintf(buf, PAGE_SIZE, "%i\n", size);
+       return snprintf(buf, PAGE_SIZE, "%u\n", size);
 }
 
 static ssize_t max_read_buffer_kb_store(struct device *csdev,
@@ -353,7 +353,7 @@ static ssize_t read_buffer_kb_show(struct device *csdev,
        mutex_unlock(&dev->mutex);
 
        comedi_dev_put(dev);
-       return snprintf(buf, PAGE_SIZE, "%i\n", size);
+       return snprintf(buf, PAGE_SIZE, "%u\n", size);
 }
 
 static ssize_t read_buffer_kb_store(struct device *csdev,
@@ -410,7 +410,7 @@ static ssize_t max_write_buffer_kb_show(struct device *csdev,
        mutex_unlock(&dev->mutex);
 
        comedi_dev_put(dev);
-       return snprintf(buf, PAGE_SIZE, "%i\n", size);
+       return snprintf(buf, PAGE_SIZE, "%u\n", size);
 }
 
 static ssize_t max_write_buffer_kb_store(struct device *csdev,
@@ -466,7 +466,7 @@ static ssize_t write_buffer_kb_show(struct device *csdev,
        mutex_unlock(&dev->mutex);
 
        comedi_dev_put(dev);
-       return snprintf(buf, PAGE_SIZE, "%i\n", size);
+       return snprintf(buf, PAGE_SIZE, "%u\n", size);
 }
 
 static ssize_t write_buffer_kb_store(struct device *csdev,
index 406aedb5382e9802cd6255da5a824faf02872e3c..8450c99af8b05466330b1ec878a3053c9d48659b 100644 (file)
@@ -211,7 +211,7 @@ static int do_dev_config(struct comedi_device *dev, struct comedi_devconfig *it)
                        return -EINVAL;
                }
 
-               snprintf(file, sizeof(file), "/dev/comedi%u", minor);
+               snprintf(file, sizeof(file), "/dev/comedi%d", minor);
                file[sizeof(file) - 1] = 0;
 
                d = comedi_open(file);
@@ -264,7 +264,7 @@ static int do_dev_config(struct comedi_device *dev, struct comedi_devconfig *it)
                                char buf[20];
                                int left =
                                    MAX_BOARD_NAME - strlen(devpriv->name) - 1;
-                               snprintf(buf, sizeof(buf), "%d:%d ",
+                               snprintf(buf, sizeof(buf), "%u:%u ",
                                         bdev->minor, bdev->subdev);
                                buf[sizeof(buf) - 1] = 0;
                                strncat(devpriv->name, buf, left);