mm/slub.c: convert vnsprintf-static to va_format
authorFabian Frederick <fabf@skynet.be>
Wed, 4 Jun 2014 23:06:35 +0000 (16:06 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 4 Jun 2014 23:53:55 +0000 (16:53 -0700)
Inspired by Joe Perches suggestion in ntfs logging clean-up.

Signed-off-by: Fabian Frederick <fabf@skynet.be>
Acked-by: Christoph Lameter <cl@linux.com>
Cc: Joe Perches <joe@perches.com>
Cc: Pekka Enberg <penberg@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/slub.c

index 1594b14e259727df24be074d8ab819c33ae019cb..de99d500af6cdf6de6881ea8d809669c5994ec34 100644 (file)
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -578,28 +578,30 @@ static void print_page_info(struct page *page)
 
 static void slab_bug(struct kmem_cache *s, char *fmt, ...)
 {
+       struct va_format vaf;
        va_list args;
-       char buf[100];
 
        va_start(args, fmt);
-       vsnprintf(buf, sizeof(buf), fmt, args);
-       va_end(args);
+       vaf.fmt = fmt;
+       vaf.va = &args;
        pr_err("=============================================================================\n");
-       pr_err("BUG %s (%s): %s\n", s->name, print_tainted(), buf);
+       pr_err("BUG %s (%s): %pV\n", s->name, print_tainted(), &vaf);
        pr_err("-----------------------------------------------------------------------------\n\n");
 
        add_taint(TAINT_BAD_PAGE, LOCKDEP_NOW_UNRELIABLE);
+       va_end(args);
 }
 
 static void slab_fix(struct kmem_cache *s, char *fmt, ...)
 {
+       struct va_format vaf;
        va_list args;
-       char buf[100];
 
        va_start(args, fmt);
-       vsnprintf(buf, sizeof(buf), fmt, args);
+       vaf.fmt = fmt;
+       vaf.va = &args;
+       pr_err("FIX %s: %pV\n", s->name, &vaf);
        va_end(args);
-       pr_err("FIX %s: %s\n", s->name, buf);
 }
 
 static void print_trailer(struct kmem_cache *s, struct page *page, u8 *p)