NFC: st21nfca: Remove skb_pipe_list and skb_pipe_info useless allocation
authorChristophe Ricard <christophe.ricard@gmail.com>
Sun, 25 Jan 2015 22:33:26 +0000 (23:33 +0100)
committerSamuel Ortiz <sameo@linux.intel.com>
Mon, 26 Jan 2015 22:14:34 +0000 (23:14 +0100)
skb_pipe_list and skb_pipe_info are allocated in nfc_hci_send_cmd.
alloc_skb on those buffer are then useless.

Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/nfc/st21nfca/st21nfca.c

index 880193b4a053a5f4b2dbb022f47908d323a9fb4e..0667272cca982a99d4ddc9b8327a0535731d4863 100644 (file)
@@ -118,18 +118,6 @@ static int st21nfca_hci_load_session(struct nfc_hci_dev *hdev)
                NFC_HCI_TERMINAL_HOST_ID, 0
        };
 
-       skb_pipe_list = alloc_skb(ST21NFCA_HCI_LLC_MAX_SIZE, GFP_KERNEL);
-       if (!skb_pipe_list) {
-               r = -ENOMEM;
-               goto free_list;
-       }
-
-       skb_pipe_info = alloc_skb(ST21NFCA_HCI_LLC_MAX_SIZE, GFP_KERNEL);
-       if (!skb_pipe_info) {
-               r = -ENOMEM;
-               goto free_info;
-       }
-
        /* On ST21NFCA device pipes number are dynamics
         * A maximum of 16 pipes can be created at the same time
         * If pipes are already created, hci_dev_up will fail.
@@ -212,7 +200,6 @@ static int st21nfca_hci_load_session(struct nfc_hci_dev *hdev)
        memcpy(hdev->init_data.gates, st21nfca_gates, sizeof(st21nfca_gates));
 free_info:
        kfree_skb(skb_pipe_info);
-free_list:
        kfree_skb(skb_pipe_list);
        return r;
 }