[libata] sata_sil: fix used-uninit warning
authorJeff Garzik <jeff@garzik.org>
Fri, 19 Aug 2011 03:52:36 +0000 (23:52 -0400)
committerJeff Garzik <jgarzik@pobox.com>
Fri, 19 Aug 2011 03:52:36 +0000 (23:52 -0400)
Init 'serror' to silence the following warning:

drivers/ata/sata_sil.c: In function ‘sil_interrupt’:
drivers/ata/sata_sil.c:453:14: warning: ‘serror’ may be used uninitialized in
this function [-Wuninitialized]

This is not a 'can never happen' but is nonetheless extremely unlikely.
The easiest and cleanest warning fix is simply to init the var,
rather than worry about marking the var uninit-ok.

Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/sata_sil.c

index 98c1d780f552505aac129cf2133b98576161e6ca..9dfb40b8c2c9f7727cf879d38ace79369f948c6e 100644 (file)
@@ -438,7 +438,7 @@ static void sil_host_intr(struct ata_port *ap, u32 bmdma2)
        u8 status;
 
        if (unlikely(bmdma2 & SIL_DMA_SATA_IRQ)) {
-               u32 serror;
+               u32 serror = 0xffffffff;
 
                /* SIEN doesn't mask SATA IRQs on some 3112s.  Those
                 * controllers continue to assert IRQ as long as