greybus: fix unbalanced mutex

Running "make coccicheck" on the Greybus code reports that
gb_mmc_get_ro() and gb_mmc_get_cd() can return without releasing
the mutex it acquired if there's an error.  Fix this.

Signed-off-by: Alex Elder <elder@linaro.org>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>

diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
index 4d4cfdf8edb667293ef31142f4c0680850389c3f..bdcc86923c541902b5c43094e7721e76a7d240a9 100644 (file)
--- a/drivers/staging/greybus/sdio.c
+++ b/drivers/staging/greybus/sdio.c
@@ -684,9 +684,12 @@ static int gb_mmc_get_ro(struct mmc_host *mmc)
        struct gb_sdio_host *host = mmc_priv(mmc);
 
        mutex_lock(&host->lock);
-       if (host->removed)
+       if (host->removed) {
+               mutex_unlock(&host->lock);
                return -ESHUTDOWN;
+       }
        mutex_unlock(&host->lock);
+
        return host->read_only;
 }
 
@@ -695,9 +698,12 @@ static int gb_mmc_get_cd(struct mmc_host *mmc)
        struct gb_sdio_host *host = mmc_priv(mmc);
 
        mutex_lock(&host->lock);
-       if (host->removed)
+       if (host->removed) {
+               mutex_unlock(&host->lock);
                return -ESHUTDOWN;
+       }
        mutex_unlock(&host->lock);
+
        return host->card_present;
 }