block: cfq_cpd_alloc() should use @gfp
authorTejun Heo <tj@kernel.org>
Thu, 10 Nov 2016 16:16:37 +0000 (11:16 -0500)
committerJens Axboe <axboe@fb.com>
Thu, 10 Nov 2016 17:10:04 +0000 (10:10 -0700)
cfq_cpd_alloc() which is the cpd_alloc_fn implementation for cfq was
incorrectly hard coding GFP_KERNEL instead of using the mask specified
through the @gfp parameter.  This currently doesn't cause any actual
issues because all current callers specify GFP_KERNEL.  Fix it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: e4a9bde9589f ("blkcg: replace blkcg_policy->cpd_size with ->cpd_alloc/free_fn() methods")
Signed-off-by: Jens Axboe <axboe@fb.com>
block/cfq-iosched.c

index dcbed8c9c82cbb6a8f42eeec098a4b6a135efa09..61010511c5a0286a1ce2d7db1bc37ec225b38f2c 100644 (file)
@@ -1586,7 +1586,7 @@ static struct blkcg_policy_data *cfq_cpd_alloc(gfp_t gfp)
 {
        struct cfq_group_data *cgd;
 
-       cgd = kzalloc(sizeof(*cgd), GFP_KERNEL);
+       cgd = kzalloc(sizeof(*cgd), gfp);
        if (!cgd)
                return NULL;
        return &cgd->cpd;