9p: do no return 0 from ->check_acl without actually checking
authorChristoph Hellwig <hch@lst.de>
Sat, 23 Jul 2011 15:36:38 +0000 (17:36 +0200)
committerAl Viro <viro@zeniv.linux.org.uk>
Mon, 25 Jul 2011 18:25:38 +0000 (14:25 -0400)
If we do not want to use ACLs we at least need to perform normal Unix
permission checks.  From the comment I'm not quite sure that's what
is intended, but if 0p wants to do permission checks entirely on the
server it needs to do so in ->permission, not in ->check_acl.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/9p/acl.c

index 8be87857605ce1aaea75c007a6264348f934a4d9..df4d7a171d7f2ae3f733af24c8a4981b5f023681 100644 (file)
@@ -108,7 +108,7 @@ int v9fs_check_acl(struct inode *inode, int mask)
                 * On access = client  and acl = on mode get the acl
                 * values from the server
                 */
-               return 0;
+               return -EAGAIN;
        }
        acl = v9fs_get_cached_acl(inode, ACL_TYPE_ACCESS);