i2c: mpc: delete unneeded test before of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Fri, 8 Aug 2014 10:07:42 +0000 (12:07 +0200)
committerWolfram Sang <wsa@the-dreams.de>
Fri, 8 Aug 2014 16:45:30 +0000 (18:45 +0200)
Of_node_put supports NULL as its argument, so the initial test is not
necessary.

Suggested by Uwe Kleine-König.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
@@

-if (e)
   of_node_put(e);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-mpc.c

index 6a32aa095f83c10171bda728f6ce69508d5da799..0edf630b099a094f4a332a5ba4ce5c2fc973c2f6 100644 (file)
@@ -341,8 +341,7 @@ static u32 mpc_i2c_get_sec_cfg_8xxx(void)
                        iounmap(reg);
                }
        }
-       if (node)
-               of_node_put(node);
+       of_node_put(node);
 
        return val;
 }