sunbmac: remove unnecessary setting of skb->dev
authorJon Mason <jdmason@kudzu.us>
Mon, 9 Jul 2012 14:09:32 +0000 (14:09 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 11 Jul 2012 06:24:57 +0000 (23:24 -0700)
skb->dev is being unnecessarily set during ring init and skb alloc in rx.  It is
already being set to the proper value when eth_type_trans is called on packet
receive, and the skb->dev is not referenced anywhere else in the code.

Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sun/sunbmac.c

index 2a83fc57edba58efd1ae7163ddd91bc70aff72d3..967fe8cb476e56eda49013963a347f262712536d 100644 (file)
@@ -233,7 +233,6 @@ static void bigmac_init_rings(struct bigmac *bp, int from_irq)
                        continue;
 
                bp->rx_skbs[i] = skb;
-               skb->dev = dev;
 
                /* Because we reserve afterwards. */
                skb_put(skb, ETH_FRAME_LEN);
@@ -838,7 +837,6 @@ static void bigmac_rx(struct bigmac *bp)
                                         RX_BUF_ALLOC_SIZE - 34,
                                         DMA_FROM_DEVICE);
                        bp->rx_skbs[elem] = new_skb;
-                       new_skb->dev = bp->dev;
                        skb_put(new_skb, ETH_FRAME_LEN);
                        skb_reserve(new_skb, 34);
                        this->rx_addr =