Staging: crystalhd: Get rid of unecessary BCMLOG_ENTER macro

The BCMLOG_ENTER macro is used only in five functions, perhaps
it is remainder of debugging some specific problem,
now, this macro don't seems to be useful, so it should be removed.

Signed-off-by: Jorgyano Vieira <jorgyano@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/crystalhd/crystalhd_hw.c b/drivers/staging/crystalhd/crystalhd_hw.c
index eeddee9a6050632fd08cc56b38792502c1e81cab..2d02ed2c77af04d99193af20da9676ea986ce458 100644 (file)
--- a/drivers/staging/crystalhd/crystalhd_hw.c
+++ b/drivers/staging/crystalhd/crystalhd_hw.c
@@ -1627,7 +1627,6 @@ enum BC_STATUS crystalhd_download_fw(struct crystalhd_adp *adp, void *buffer, ui
        uint32_t fw_sig_len = 36;
        uint32_t dram_offset = BC_FWIMG_ST_ADDR, sig_reg;
 
-       BCMLOG_ENTER;
 
        if (!adp || !buffer || !sz) {
                BCMLOG_ERR("Invalid Params.\n");
@@ -1724,8 +1723,6 @@ enum BC_STATUS crystalhd_do_fw_cmd(struct crystalhd_hw *hw,
 
        crystalhd_create_event(&fw_cmd_event);
 
-       BCMLOG_ENTER;
-
        if (!hw || !fw_cmd) {
                BCMLOG_ERR("Invalid Arguments\n");
                return BC_STS_INV_ARG;

diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c b/drivers/staging/crystalhd/crystalhd_lnx.c
index 7e0c199f68939cf03b7e96328061aaeca3d4f561..9dca92c9557725865f862f7fecbcc4d4ed7368a4 100644 (file)
--- a/drivers/staging/crystalhd/crystalhd_lnx.c
+++ b/drivers/staging/crystalhd/crystalhd_lnx.c
@@ -298,7 +298,6 @@ static int chd_dec_open(struct inode *in, struct file *fd)
        enum BC_STATUS sts = BC_STS_SUCCESS;
        struct crystalhd_user *uc = NULL;
 
-       BCMLOG_ENTER;
        if (!adp) {
                BCMLOG_ERR("Invalid adp\n");
                return -EINVAL;
@@ -327,7 +326,6 @@ static int chd_dec_close(struct inode *in, struct file *fd)
        struct crystalhd_adp *adp = chd_get_adp();
        struct crystalhd_user *uc;
 
-       BCMLOG_ENTER;
        if (!adp) {
                BCMLOG_ERR("Invalid adp\n");
                return -EINVAL;
@@ -513,8 +511,6 @@ static void __devexit chd_dec_pci_remove(struct pci_dev *pdev)
        struct crystalhd_adp *pinfo;
        enum BC_STATUS sts = BC_STS_SUCCESS;
 
-       BCMLOG_ENTER;
-
        pinfo = pci_get_drvdata(pdev);
        if (!pinfo) {
                BCMLOG_ERR("could not get adp\n");

diff --git a/drivers/staging/crystalhd/crystalhd_misc.h b/drivers/staging/crystalhd/crystalhd_misc.h
index eedd9b70465cc5416eeb5a14cd243d58221fe51d..d2f7256146e485c76aab8f1ea3d54a0dca38987f 100644 (file)
--- a/drivers/staging/crystalhd/crystalhd_misc.h
+++ b/drivers/staging/crystalhd/crystalhd_misc.h
@@ -200,15 +200,8 @@ enum _chd_log_levels {
        BCMLOG_INFO             = 0x00000001,   /* Generic informational */
        BCMLOG_DBG              = 0x00000002,   /* First level Debug info */
        BCMLOG_SSTEP            = 0x00000004,   /* Stepping information */
-       BCMLOG_ENTER_LEAVE      = 0x00000008,   /* stack tracking */
 };
 
-#define BCMLOG_ENTER                                           \
-do {                                                           \
-       if (g_linklog_level & BCMLOG_ENTER_LEAVE)               \
-               printk(KERN_DEBUG "Entered %s\n", __func__);    \
-} while (0)
-
 
 #define BCMLOG(trace, fmt, args...)    \
 do {                                   \