staging: fbtft: use strncpy instead of strcpy
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Sat, 5 Sep 2015 13:43:43 +0000 (19:13 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 13 Sep 2015 01:24:53 +0000 (18:24 -0700)
Using strcpy() is a security risk as the destination buffer size is not
checked and we may over-run the buffer. Use strncpy() instead, while
mentioning the buffer size leaving place for the NULL termination.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/fbtft/fbtft_device.c

index 0483d33b2638fa1e4afbc67d555035a5c966787e..3856c8873f63df896790007a3b19f9cc9e44eb28 100644 (file)
@@ -1342,7 +1342,8 @@ static int __init fbtft_device_init(void)
                                p_name, p_num);
                        return -EINVAL;
                }
-               strcpy(fbtft_device_param_gpios[i].name, p_name);
+               strncpy(fbtft_device_param_gpios[i].name, p_name,
+                       FBTFT_GPIO_NAME_SIZE - 1);
                fbtft_device_param_gpios[i++].gpio = (int) val;
                if (i == MAX_GPIOS) {
                        pr_err(DRVNAME