projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: f77ac91)
ALSA: bebob: Correction for return value of special_clk_ctl_put() in error
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Tue, 22 Jul 2014 15:02:08 +0000 (00:02 +0900)
committerTakashi Iwai <tiwai@suse.de>
Tue, 22 Jul 2014 15:31:28 +0000 (17:31 +0200)
This commit is a supplement to my previous patch.
http://mailman.alsa-project.org/pipermail/alsa-devel/2014-July/079190.html

The special_clk_ctl_put() still returns 0 in error handling case. It should
return -EINVAL.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/bebob/bebob_maudio.c patch | blob | blame | history

diff --git a/sound/firewire/bebob/bebob_maudio.c b/sound/firewire/bebob/bebob_maudio.c
index d6d6ff8cb8dd3923124781a3c29922a89fd2002f..70faa3a325264a68511a2edca0efa225ebe40942 100644 (file)
--- a/sound/firewire/bebob/bebob_maudio.c
+++ b/sound/firewire/bebob/bebob_maudio.c
@@ -381,7 +381,7 @@ static int special_clk_ctl_put(struct snd_kcontrol *kctl,
 
        id = uval->value.enumerated.item[0];
        if (id >= ARRAY_SIZE(special_clk_labels))
-               return 0;
+               return -EINVAL;
 
        mutex_lock(&bebob->mutex);