net: ipv4: remove disable of bottom half in inet_rtm_getroute
authorDavid Ahern <dsa@cumulusnetworks.com>
Sun, 8 Jan 2017 04:04:23 +0000 (20:04 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 9 Jan 2017 18:54:44 +0000 (13:54 -0500)
Nothing about the route lookup requires bottom half to be disabled.
Remove the local_bh_disable ... local_bh_enable around ip_route_input.
This appears to be a vestige of days gone by as it has been there
since the beginning of git time.

Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/route.c

index f51823dc998bbe2c19ceac4e471e82b0e4b1eaf3..7144288371cfd9b3f1a0e527d6fbd7d098bca0fa 100644 (file)
@@ -2631,9 +2631,7 @@ static int inet_rtm_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh)
                skb->protocol   = htons(ETH_P_IP);
                skb->dev        = dev;
                skb->mark       = mark;
-               local_bh_disable();
                err = ip_route_input(skb, dst, src, rtm->rtm_tos, dev);
-               local_bh_enable();
 
                rt = skb_rtable(skb);
                if (err == 0 && rt->dst.error)