xen: make use of xenbus_read_unsigned() in xen-fbfront
authorJuergen Gross <jgross@suse.com>
Mon, 31 Oct 2016 13:58:41 +0000 (14:58 +0100)
committerJuergen Gross <jgross@suse.com>
Mon, 7 Nov 2016 12:55:32 +0000 (13:55 +0100)
Use xenbus_read_unsigned() instead of xenbus_scanf() when possible.
This requires to change the type of the reads from int to unsigned,
but these cases have been wrong before: negative values are not allowed
for the modified cases.

Cc: tomi.valkeinen@ti.com
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: David Vrabel <david.vrabel@citrix.com>
drivers/video/fbdev/xen-fbfront.c

index 0567d517eed34b2993a2bdf6df963ab55564297a..d0115a7af0a9ae0f3171a66bf716f0f21c3e91b1 100644 (file)
@@ -633,7 +633,6 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
                                  enum xenbus_state backend_state)
 {
        struct xenfb_info *info = dev_get_drvdata(&dev->dev);
-       int val;
 
        switch (backend_state) {
        case XenbusStateInitialising:
@@ -657,16 +656,12 @@ InitWait:
                if (dev->state != XenbusStateConnected)
                        goto InitWait; /* no InitWait seen yet, fudge it */
 
-               if (xenbus_scanf(XBT_NIL, info->xbdev->otherend,
-                                "request-update", "%d", &val) < 0)
-                       val = 0;
-               if (val)
+               if (xenbus_read_unsigned(info->xbdev->otherend,
+                                        "request-update", 0))
                        info->update_wanted = 1;
 
-               if (xenbus_scanf(XBT_NIL, dev->otherend,
-                                "feature-resize", "%d", &val) < 0)
-                       val = 0;
-               info->feature_resize = val;
+               info->feature_resize = xenbus_read_unsigned(dev->otherend,
+                                                       "feature-resize", 0);
                break;
 
        case XenbusStateClosed: