x86/PCI: remove 64-bit division
authorBjorn Helgaas <bjorn.helgaas@hp.com>
Thu, 5 Nov 2009 17:17:11 +0000 (11:17 -0600)
committerJesse Barnes <jbarnes@virtuousgeek.org>
Fri, 6 Nov 2009 21:59:34 +0000 (13:59 -0800)
The roundup() caused a build error (undefined reference to `__udivdi3').
We're aligning to power-of-two boundaries, so it's simpler to just use
ALIGN() anyway, which avoids the division.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
arch/x86/pci/acpi.c

index 8ddf4f4c725314b8886a58e47184f0a8f8f2e30f..959e548a7039e81a85cdd0e7eb114a86f91a05c5 100644 (file)
@@ -69,17 +69,17 @@ align_resource(struct acpi_device *bridge, struct resource *res)
         * that claim this address space have starting alignment and length
         * constraints, so fix any obvious BIOS goofs.
         */
-       if (res->start & (align - 1)) {
+       if (!IS_ALIGNED(res->start, align)) {
                dev_printk(KERN_DEBUG, &bridge->dev,
                           "host bridge window %pR invalid; "
                           "aligning start to %d-byte boundary\n", res, align);
                res->start &= ~(align - 1);
        }
-       if ((res->end + 1) & (align - 1)) {
+       if (!IS_ALIGNED(res->end + 1, align)) {
                dev_printk(KERN_DEBUG, &bridge->dev,
                           "host bridge window %pR invalid; "
                           "aligning end to %d-byte boundary\n", res, align);
-               res->end = roundup(res->end, align) - 1;
+               res->end = ALIGN(res->end, align) - 1;
        }
 }