media: blackfin: bfin_capture: constify vb2_ops structures
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 5 Aug 2017 10:47:11 +0000 (06:47 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sun, 20 Aug 2017 12:03:33 +0000 (08:03 -0400)
These vb2_ops structures are only stored in the ops field of a
vb2_queue structure, which is declared as const.  Thus the vb2_ops
structures themselves can be const.

Done with the help of Coccinelle.

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct vb2_ops i@p = { ... };

@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct vb2_ops i = { ... };
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/blackfin/bfin_capture.c

index 294d696c4a3b48e3e374d4a4068687e9cd03b92d..41f179117fb09c70b6304493a9a25eae7f237c06 100644 (file)
@@ -375,7 +375,7 @@ static void bcap_stop_streaming(struct vb2_queue *vq)
        }
 }
 
-static struct vb2_ops bcap_video_qops = {
+static const struct vb2_ops bcap_video_qops = {
        .queue_setup            = bcap_queue_setup,
        .buf_prepare            = bcap_buffer_prepare,
        .buf_cleanup            = bcap_buffer_cleanup,