PCI: keystone: Fix error handling of irq_of_parse_and_map()
authorDmitry Torokhov <dtor@chromium.org>
Fri, 14 Nov 2014 22:19:03 +0000 (14:19 -0800)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 26 Dec 2014 23:23:35 +0000 (16:23 -0700)
Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating
failure, so testing for negative result never works.

Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-By: Murali Karicheri <m-karicheri2@ti.com>
drivers/pci/host/pci-keystone.c

index 78f79e31ac5c4a23f87978f5fe64a250e162931d..23a1d97db1dd65588055010788955720d443495e 100644 (file)
@@ -197,7 +197,7 @@ static int ks_pcie_get_irq_controller_info(struct keystone_pcie *ks_pcie,
         */
        for (temp = 0; temp < max_host_irqs; temp++) {
                host_irqs[temp] = irq_of_parse_and_map(*np_temp, temp);
-               if (host_irqs[temp] < 0)
+               if (!host_irqs[temp])
                        break;
        }
        if (temp) {