drm/i915: fix backlight invert for non-zero minimum brightness
authorJani Nikula <jani.nikula@intel.com>
Wed, 31 May 2017 08:33:55 +0000 (11:33 +0300)
committerJani Nikula <jani.nikula@intel.com>
Fri, 4 Aug 2017 12:22:18 +0000 (15:22 +0300)
When we started following the backlight minimum brightness in
6dda730e55f4 ("drm/i915: respect the VBT minimum backlight brightness")
we overlooked the brightness invert quirk. Even if we invert the
brightness, we need to take the min limit into account. We probably
missed this because the invert has only been required on gen4 for proper
operation.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101127
Fixes: 6dda730e55f4 ("drm/i915: respect the VBT minimum backlight brightness")
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20170531083355.7898-1-jani.nikula@intel.com
drivers/gpu/drm/i915/intel_panel.c

index fd2e0815f06a99eb9190629d56293f72d3fe2890..88018fccdb9fcff550c9326d525a0033070a1e8e 100644 (file)
@@ -470,7 +470,7 @@ static u32 intel_panel_compute_brightness(struct intel_connector *connector,
 
        if (i915.invert_brightness > 0 ||
            dev_priv->quirks & QUIRK_INVERT_BRIGHTNESS) {
-               return panel->backlight.max - val;
+               return panel->backlight.max - val + panel->backlight.min;
        }
 
        return val;