bnx2x: free the mac filter group list before freeing the cmd

The group list must be freed prior to freeing the command otherwise
we have a use-after-free.

Signed-off-by: Jason Baron <jbaron@akamai.com>
Cc: Yuval Mintz <Yuval.Mintz@qlogic.com>
Cc: Ariel Elior <Ariel.Elior@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
index 4947a9cbf0c1aee31ecdac0a762e398e3608ce23..cea6bdcde33f0be220815378142ea9e8dfc7ba37 100644 (file)
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
@@ -2714,8 +2714,8 @@ static int bnx2x_mcast_enqueue_cmd(struct bnx2x *bp,
                        elem_group = (struct bnx2x_mcast_elem_group *)
                                     __get_free_page(GFP_ATOMIC | __GFP_ZERO);
                        if (!elem_group) {
-                               kfree(new_cmd);
                                bnx2x_free_groups(&new_cmd->group_head);
+                               kfree(new_cmd);
                                return -ENOMEM;
                        }
                        total_elems -= MCAST_MAC_ELEMS_PER_PG;