checkkconfigsymbols.py: fix sorted output
authorValentin Rothberg <valentinrothberg@gmail.com>
Mon, 23 Mar 2015 17:40:49 +0000 (18:40 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Mar 2015 14:18:44 +0000 (15:18 +0100)
Commit b1a3f243485f ("checkkconfigsymbols.py: make it Git aware")
mistakenly removed to print undefined Kconfig symbols in alphabetical
order.  Furthermore, the script does not print anything anymore when the
entire tree is checked (i.e., when no commit is specified).

This patch restores the sorted output and adds the missing print for the
default case.  Additionally, the file lists are now sorted as well which
(a) makes it easier to read and (b) makes the output deterministic.

Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
scripts/checkkconfigsymbols.py

index ce9ca60808b8ac82034d574009ed8d0878eb847c..74086a583d8dddb4ecc2b880934de1a374069c48 100755 (executable)
@@ -112,14 +112,15 @@ def main():
         undefined_b = check_symbols()
 
         # report cases that are present for the commit but not before
-        for feature in undefined_b:
+        for feature in sorted(undefined_b):
             # feature has not been undefined before
             if not feature in undefined_a:
-                files = undefined_b.get(feature)
+                files = sorted(undefined_b.get(feature))
                 print "%s\t%s" % (feature, ", ".join(files))
             # check if there are new files that reference the undefined feature
             else:
-                files = undefined_b.get(feature) - undefined_a.get(feature)
+                files = sorted(undefined_b.get(feature) -
+                               undefined_a.get(feature))
                 if files:
                     print "%s\t%s" % (feature, ", ".join(files))
 
@@ -129,8 +130,9 @@ def main():
     # default to check the entire tree
     else:
         undefined = check_symbols()
-        for feature in undefined:
-            files = undefined.get(feature)
+        for feature in sorted(undefined):
+            files = sorted(undefined.get(feature))
+            print "%s\t%s" % (feature, ", ".join(files))
 
 
 def execute(cmd):