ASoC: designware_i2s: Remove unnecessary dev_set_drvdata()
authorFabio Estevam <fabio.estevam@freescale.com>
Mon, 26 Aug 2013 12:25:15 +0000 (09:25 -0300)
committerMark Brown <broonie@linaro.org>
Thu, 29 Aug 2013 12:18:32 +0000 (13:18 +0100)
Driver core clears the driver data to NULL after device_release or on probe
failure, so just remove it from here.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
sound/soc/dwc/designware_i2s.c

index 70eb37a5dd16337614abd50462521706b6f7f9b3..25c31f1655f682f3e5c630c08c8b09fdfe2901cc 100644 (file)
@@ -421,13 +421,11 @@ static int dw_i2s_probe(struct platform_device *pdev)
                                         dw_i2s_dai, 1);
        if (ret != 0) {
                dev_err(&pdev->dev, "not able to register dai\n");
-               goto err_set_drvdata;
+               goto err_clk_disable;
        }
 
        return 0;
 
-err_set_drvdata:
-       dev_set_drvdata(&pdev->dev, NULL);
 err_clk_disable:
        clk_disable(dev->clk);
 err_clk_put:
@@ -440,7 +438,6 @@ static int dw_i2s_remove(struct platform_device *pdev)
        struct dw_i2s_dev *dev = dev_get_drvdata(&pdev->dev);
 
        snd_soc_unregister_component(&pdev->dev);
-       dev_set_drvdata(&pdev->dev, NULL);
 
        clk_put(dev->clk);