ARM: OMAP2+: return -ENODEV if GPMC child device creation fails
authorJavier Martinez Canillas <javier.martinez@collabora.co.uk>
Thu, 14 Mar 2013 15:09:20 +0000 (16:09 +0100)
committerJon Hunter <jon-hunter@ti.com>
Thu, 4 Apr 2013 01:13:41 +0000 (20:13 -0500)
gpmc_probe_nor_child() calls of_platform_device_create() to create a
platform device for the NOR child. If this function fails the value
of ret is returned to the caller but this value is zero since it was
assigned the return of a previous call to gpmc_cs_program_settings()
that had to succeed or otherwise gpmc_probe_nor_child() would have
returned before.

This means that if of_platform_device_create() fails, 0 will be returned
to the caller instead of an appropriate error code.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Signed-off-by: Jon Hunter <jon-hunter@ti.com>
Tested-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
arch/arm/mach-omap2/gpmc.c

index 5f6af202807ac9644a42088dbc478cc14eb20ed5..c6f0ef5638173aea2ad0114ac34ddd99f7d1c3f9 100644 (file)
@@ -1495,6 +1495,7 @@ static int gpmc_probe_nor_child(struct platform_device *pdev,
                return 0;
 
        dev_err(&pdev->dev, "failed to create gpmc child %s\n", child->name);
+       ret = -ENODEV;
 
 err:
        gpmc_cs_free(cs);