brcmfmac: rename brcmf_bus_start function to brcmf_bus_started
authorRafał Miłecki <rafal@milecki.pl>
Wed, 18 Jan 2017 10:48:54 +0000 (11:48 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 20 Jan 2017 10:03:57 +0000 (12:03 +0200)
This intends to make init/attach process slightly easier to follow.

What driver was doing in brcmf_bus_start wasn't bus specific at all and
function brcmf_bus_stop wasn't undoing things done there. This function
is supposed to be called by bus specific code when the bus is ready.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h
drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c

index b5bb971ef56a330b2bd8ff2a8126bd4f87440c1c..76693df347425951397a211c863f19046dbf07f5 100644 (file)
@@ -238,7 +238,7 @@ void brcmf_txcomplete(struct device *dev, struct sk_buff *txp, bool success);
 /* Configure the "global" bus state used by upper layers */
 void brcmf_bus_change_state(struct brcmf_bus *bus, enum brcmf_bus_state state);
 
-int brcmf_bus_start(struct device *dev);
+int brcmf_bus_started(struct device *dev);
 s32 brcmf_iovar_data_set(struct device *dev, char *name, void *data, u32 len);
 void brcmf_bus_add_txhdrlen(struct device *dev, uint len);
 
index b1f574f5ee6ce8382c20c3100091b28866f46b0c..f7c8c2e80349d2f50667f312f303270aeb5994bb 100644 (file)
@@ -74,7 +74,7 @@ module_param_named(roamoff, brcmf_roamoff, int, S_IRUSR);
 MODULE_PARM_DESC(roamoff, "Do not use internal roaming engine");
 
 #ifdef DEBUG
-/* always succeed brcmf_bus_start() */
+/* always succeed brcmf_bus_started() */
 static int brcmf_ignore_probe_fail;
 module_param_named(ignore_probe_fail, brcmf_ignore_probe_fail, int, 0);
 MODULE_PARM_DESC(ignore_probe_fail, "always succeed probe for debugging");
index 372d2c480f29702f8696970e53a4dd674dc426fc..b73a55b00fa7402cf02b626fe710deb2e7188fc3 100644 (file)
@@ -966,7 +966,7 @@ static int brcmf_revinfo_read(struct seq_file *s, void *data)
        return 0;
 }
 
-int brcmf_bus_start(struct device *dev)
+int brcmf_bus_started(struct device *dev)
 {
        int ret = -1;
        struct brcmf_bus *bus_if = dev_get_drvdata(dev);
index 048027f2085bbd293abe878ba2b2821ba6452804..19db8f26729a7e600194731b603a6573fe86f2d3 100644 (file)
@@ -1572,7 +1572,7 @@ static int brcmf_pcie_attach_bus(struct brcmf_pciedev_info *devinfo)
        if (ret) {
                brcmf_err("brcmf_attach failed\n");
        } else {
-               ret = brcmf_bus_start(&devinfo->pdev->dev);
+               ret = brcmf_bus_started(&devinfo->pdev->dev);
                if (ret)
                        brcmf_err("dongle is not responding\n");
        }
index d2219885071f6d718f0f26320d580c66adc26e36..c5744b45ec8fbc6bb67539647d6db4a8afa4a465 100644 (file)
@@ -4065,7 +4065,7 @@ static void brcmf_sdio_firmware_callback(struct device *dev,
 
        sdio_release_host(sdiodev->func[1]);
 
-       err = brcmf_bus_start(dev);
+       err = brcmf_bus_started(dev);
        if (err != 0) {
                brcmf_err("dongle is not responding\n");
                goto fail;
index 2f978a39b58a49485209f1da9f4f1a5c22647307..d93ebbdc773757adda218b16b816c30202792973 100644 (file)
@@ -1148,7 +1148,7 @@ static int brcmf_usb_bus_setup(struct brcmf_usbdev_info *devinfo)
        if (ret)
                goto fail;
 
-       ret = brcmf_bus_start(devinfo->dev);
+       ret = brcmf_bus_started(devinfo->dev);
        if (ret)
                goto fail;