drivers/staging: Use RCU_INIT_POINTER(x, NULL) in fwserial/fwserial.c
authorMonam Agarwal <monamagarwal123@gmail.com>
Sun, 23 Mar 2014 18:38:22 +0000 (00:08 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2014 21:01:40 +0000 (14:01 -0700)
This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure
is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize.
So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/fwserial/fwserial.c

index 9758c351026f1c5e4e7514ad6bc5100a65d7acc5..384758b11e3c15ca6b0c96e07c1c399b23d7d159 100644 (file)
@@ -1807,7 +1807,7 @@ static void fwserial_release_port(struct fwtty_port *port, bool reset)
        port->max_payload = link_speed_to_max_payload(SCODE_100);
        dma_fifo_change_tx_limit(&port->tx_fifo, port->max_payload);
 
-       rcu_assign_pointer(port->peer, NULL);
+       RCU_INIT_POINTER(port->peer, NULL);
        spin_unlock_bh(&port->lock);
 
        if (port->port.console && port->fwcon_ops->notify != NULL)
@@ -2240,7 +2240,7 @@ static int fwserial_create(struct fw_unit *unit)
                port->max_payload = link_speed_to_max_payload(SCODE_100);
                dma_fifo_init(&port->tx_fifo);
 
-               rcu_assign_pointer(port->peer, NULL);
+               RCU_INIT_POINTER(port->peer, NULL);
                serial->ports[i] = port;
 
                /* get unique bus addr region for port's status & recv fifo */