usb: misc: cypress_cy7c63: don't print on ENOMEM
authorWolfram Sang <wsa-dev@sang-engineering.com>
Thu, 25 Aug 2016 17:39:13 +0000 (19:39 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Aug 2016 17:17:37 +0000 (19:17 +0200)
All kmalloc-based functions print enough information on failures.

Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/cypress_cy7c63.c

index 402b94dd25315959dec45d1196c05af227bc32f5..5c93a888c40e565eec60ab8ecfdeaf68b9f3310a 100644 (file)
@@ -79,7 +79,6 @@ static int vendor_command(struct cypress *dev, unsigned char request,
        /* allocate some memory for the i/o buffer*/
        iobuf = kzalloc(CYPRESS_MAX_REQSIZE, GFP_KERNEL);
        if (!iobuf) {
-               dev_err(&dev->udev->dev, "Out of memory!\n");
                retval = -ENOMEM;
                goto error;
        }
@@ -208,10 +207,8 @@ static int cypress_probe(struct usb_interface *interface,
 
        /* allocate memory for our device state and initialize it */
        dev = kzalloc(sizeof(*dev), GFP_KERNEL);
-       if (dev == NULL) {
-               dev_err(&interface->dev, "Out of memory!\n");
+       if (!dev)
                goto error_mem;
-       }
 
        dev->udev = usb_get_dev(interface_to_usbdev(interface));