hv_netvsc: pass struct net_device to rndis_filter_set_device_mac()
authorVitaly Kuznetsov <vkuznets@redhat.com>
Fri, 3 Jun 2016 15:51:01 +0000 (17:51 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 6 Jun 2016 03:16:36 +0000 (23:16 -0400)
We unpack 'struct net_device' in netvsc_set_mac_addr() to get to
'struct hv_device' pointer which we use in rndis_filter_set_device_mac()
to get back to 'struct net_device'.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/hyperv/hyperv_net.h
drivers/net/hyperv/netvsc_drv.c
drivers/net/hyperv/rndis_filter.c

index f650ec14c7cde79e6ed57453fdae6216bb2226cd..467fb8b4d08389b00fbca446bae9261e2145b909 100644 (file)
@@ -201,7 +201,7 @@ int rndis_filter_receive(struct hv_device *dev,
                        struct vmbus_channel *channel);
 
 int rndis_filter_set_packet_filter(struct rndis_device *dev, u32 new_filter);
-int rndis_filter_set_device_mac(struct hv_device *hdev, char *mac);
+int rndis_filter_set_device_mac(struct net_device *ndev, char *mac);
 
 void netvsc_switch_datapath(struct net_device *nv_dev, bool vf);
 
index 2492f83d2bd57de07c45ad9284a3b25c0ab4505d..787a20235e5caa16063aecef89c3b6a335a1d628 100644 (file)
@@ -982,8 +982,6 @@ static struct rtnl_link_stats64 *netvsc_get_stats64(struct net_device *net,
 
 static int netvsc_set_mac_addr(struct net_device *ndev, void *p)
 {
-       struct net_device_context *ndevctx = netdev_priv(ndev);
-       struct hv_device *hdev =  ndevctx->device_ctx;
        struct sockaddr *addr = p;
        char save_adr[ETH_ALEN];
        unsigned char save_aatype;
@@ -996,7 +994,7 @@ static int netvsc_set_mac_addr(struct net_device *ndev, void *p)
        if (err != 0)
                return err;
 
-       err = rndis_filter_set_device_mac(hdev, addr->sa_data);
+       err = rndis_filter_set_device_mac(ndev, addr->sa_data);
        if (err != 0) {
                /* roll back to saved MAC */
                memcpy(ndev->dev_addr, save_adr, ETH_ALEN);
index 2c2f3b92cc4af3549746161e180a5a169ed76e3f..f1692bcd19bec0d9c4cd5caa0beca1c67f7abf09 100644 (file)
@@ -543,9 +543,8 @@ static int rndis_filter_query_device_mac(struct rndis_device *dev)
 #define NWADR_STR "NetworkAddress"
 #define NWADR_STRLEN 14
 
-int rndis_filter_set_device_mac(struct hv_device *hdev, char *mac)
+int rndis_filter_set_device_mac(struct net_device *ndev, char *mac)
 {
-       struct net_device *ndev = hv_get_drvdata(hdev);
        struct netvsc_device *nvdev = net_device_to_netvsc_device(ndev);
        struct rndis_device *rdev = nvdev->extension;
        struct rndis_request *request;