fs: move get_empty_filp() deffinition to internal.h

All users outside of fs/ of get_empty_filp() have been removed.  This patch
moves the definition from the include/ directory to internal.h so no new
users crop up and removes the EXPORT_SYMBOL.  I'd love to see open intents
stop using it too, but that's a problem for another day and a smarter
developer!

Signed-off-by: Eric Paris <eparis@redhat.com>
Acked-by: Miklos Szeredi <miklos@szeredi.hu>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

diff --git a/fs/file_table.c b/fs/file_table.c
index 163cd28314e04b05c1b22fe11fb079fd89d84a4b..361d76be8295b248c14f076f31ef73c47b591a0e 100644 (file)
--- a/fs/file_table.c
+++ b/fs/file_table.c
@@ -24,6 +24,8 @@
 
 #include <asm/atomic.h>
 
+#include "internal.h"
+
 /* sysctl tunables... */
 struct files_stat_struct files_stat = {
        .max_files = NR_FILE

diff --git a/fs/internal.h b/fs/internal.h
index 515175b8b72e95f47893d3b1f32017da481e0aec..f67cd141d9a8073bacdf672c12ec91f1deebdd27 100644 (file)
--- a/fs/internal.h
+++ b/fs/internal.h
@@ -79,6 +79,7 @@ extern void chroot_fs_refs(struct path *, struct path *);
  * file_table.c
  */
 extern void mark_files_ro(struct super_block *);
+extern struct file *get_empty_filp(void);
 
 /*
  * super.c

diff --git a/fs/namei.c b/fs/namei.c
index 8c8b379b94a423c1e02d70f58cb28233fd7aaca4..1fc038b117bea1156d7e0f6fdba60f994f3f55fe 100644 (file)
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -35,6 +35,8 @@
 #include <linux/fs_struct.h>
 #include <asm/uaccess.h>
 
+#include "internal.h"
+
 #define ACC_MODE(x) ("\000\004\002\006"[(x)&O_ACCMODE])
 
 /* [Feb-1997 T. Schoebel-Theuer]

diff --git a/fs/open.c b/fs/open.c
index b4b31d277f3aa537efe1ebaa9d847dca86835214..d95651e8be9ed4ce73b06c0067a7d4d09ec98775 100644 (file)
--- a/fs/open.c
+++ b/fs/open.c
@@ -31,6 +31,8 @@
 #include <linux/falloc.h>
 #include <linux/fs_struct.h>
 
+#include "internal.h"
+
 int vfs_statfs(struct dentry *dentry, struct kstatfs *buf)
 {
        int retval = -ENODEV;

diff --git a/include/linux/fs.h b/include/linux/fs.h
index a057f48eb156ca2fb015ddedabd3dbb1da473f1b..cdc23be4eddeb2dc682c89fe5ce8e77b394a9583 100644 (file)
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2189,7 +2189,6 @@ static inline void insert_inode_hash(struct inode *inode) {
        __insert_inode_hash(inode, inode->i_ino);
 }
 
-extern struct file * get_empty_filp(void);
 extern void file_move(struct file *f, struct list_head *list);
 extern void file_kill(struct file *f);
 #ifdef CONFIG_BLOCK